fix: resolve issue when updating or adding content type #998
Conversation
|
Hello @ratorik, thanks so much for your contribution. 🙌 Would it be possible to add a test for this addition, so we can avoid any regression in the future? |
|
Hey @Strift, Thanks for your feedback! I'll look into adding a test for this to help prevent regressions. That said, as mentioned in the ticket by @daandegooijer, the best long-term solution might be to revamp the lifecycles and align with the Strapi documentation. Since this was just a quick fix, maybe it makes sense to address the broader issue instead? Let me know what you think! |
|
Hi @ratorik, I think it's better to submit this small fix first, and then work on the broader fix in a second step. Refactoring a bigger part of the codebase will make the review process more heavy. As a result, changes would get deployed more slowly. So I'd recommend adding the tests for this PR and then working on the revamp. If you have the bandwidth to work on it, a broader fix would be welcome. Just consider that it could take me and other contributors a longer time to review it. |
|
Hey, I saw this is WIP but just thought I would send a reminder to translate comments in English before submitting for review again 🙏 |
…abled fix: resolve Meilisearch issue with draftAndPublish enabled When updating or adding an item with draftAndPublish enabled, the item is removed from Meilisearch, and the following error occurs: error: Meilisearch could not add entry with id: 9: Transaction query already complete This issue is described in meilisearch#997. The item should update correctly without errors when draftAndPublish is enabled.
…terUpdate, afterUpdateMany, afterDelete and afterDeleteMany
ratorik
force-pushed
the
fix/issue-when-creating-or-updating-a-entry
branch
from
f4f692b to
336d24e
Compare
ratorik
changed the title
fix: resolve Meilisearch issue with draftAndPublish enabled
When updating or adding an item with draftAndPublish enabled, the item is removed from Meilisearch, and the following error occurs:
error: Meilisearch could not add entry with id: 9: Transaction query already complete
This issue is described in #997. The item should update correctly without errors when draftAndPublish is enabled.
Pull Request
Related issue
Fixes #997
What does this PR do?