docs: the two settings the reference called broken now work - #252
Merged
Conversation
MEI-139 and MEI-140 landed after the reference that documented them as defects, so three passages described bugs the code no longer has. The first-post moderation warning and the promotion warning in the organiser guide are removed outright — both said "does not currently", and it now does. The groups reference kept its paragraph on the no-demotion guard, rewritten to say what the guard does today: a group it does not rank is not compared at all, so a rule into a group you made runs normally, and a move between two ranked groups in the wrong direction is still refused. The line worth keeping from it is that the guard was never what protected staff — a member in a protected group is skipped before any rank is considered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow-up I said I'd push. #250 (the administrator reference) and #251 (the fixes) both merged, in that order — so
maincurrently carries three passages documenting bugs the code no longer has.What was stale
docs/antispam.mdantispam.moderate_first_postsdoes not currently hold anything" — with a workaround telling operators to use the per-forum approval switches insteaddocs/organiser-guide.mddocs/groups.md0, so a rule … is passed over as a demotion"The first two are removed outright — both said "does not currently", and it now does. The table row that pointed at the warning ("Most forum spam — but see the warning below") loses its caveat.
What was kept, rewritten
docs/groups.md's paragraph on the no-demotion guard stays, because the guard still exists and an operator writing a rule needs to know what it refuses. It now describes today's behaviour: a group it does not rank is not compared at all, so a rule into a group you made runs normally, while a move between two ranked groups in the wrong direction is still refused.It also keeps the sentence worth keeping from the investigation — the rank guard was never what protected staff. A member whose primary group is Banned, Administrators or Super moderators is skipped before any rank is considered. That is the thing an operator should rely on, and it was true before and after the fix.
Verification
docs:links:check(34 documents, 691 headings),docs:index:checkandsite:docs:checkall pass. Grepped for any remaining "does not currently", "is currently refused" or "until this is fixed" acrossdocs/— none.Documentation only.
Generated by Claude Code