Skip to content

Add GitHub Actions workflow for PR testing #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oxygen-dioxide wants to merge 1 commit into from
Closed

Add GitHub Actions workflow for PR testing #340

oxygen-dioxide wants to merge 1 commit into from

Conversation

@oxygen-dioxide
Copy link

@oxygen-dioxide oxygen-dioxide commented Dec 6, 2025

No description provided.

@melanchall
Copy link
Owner

melanchall commented Dec 6, 2025

Thank you for the PR, but I'm going to reject it:

  1. It's wrong to just call dotnet test because some tests require additional setup procedures. At least, .NET 10 should be installed as you can see from failed runs on this PR.
  2. You may notice that a bunch of Azure Pipelines have been run on this PR (they were skipped due to no changes in the code). So I already have checks for PRs.

@melanchall melanchall closed this Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oxygen-dioxide @melanchall