Make allow_extra_fields as default - #99
Merged
Merged
Conversation
pedrobslisboa
force-pushed
the
pedrolisboa/allow_extra_fields_default
branch
from
July 6, 2026 18:00
aef6f98 to
0667318
Compare
pedrobslisboa
force-pushed
the
pedrolisboa/allow_extra_fields_default
branch
from
July 6, 2026 21:47
0667318 to
81b1685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Melange JSON deriver ignores unknown object keys by default, but
ppx_deriving_jsonschemagenerated"additionalProperties": falsefor records unless users opted in with[@@jsonschema.allow_extra_fields]. This made the generated schemas stricter than — and inconsistent with — the runtime decoders they're meant to describe. This change flips the default to match, mirroring melange-community/melange-json#92.What
"additionalProperties": trueby default, matching the Melange JSON deriver which ignores unknown object keys.[@@jsonschema.disallow_extra_fields](and[@jsonschema.disallow_extra_fields]on constructors with inline records in variants) to opt back into strict objects ("additionalProperties": false).[@@jsonschema.allow_extra_fields]accepted for backwards compatibility — it is now a no-op — and reject using bothallow_extra_fieldsanddisallow_extra_fieldson the same type/constructor.