Skip to content

ppx/test: cover encode behavior for @drop_default variants #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Khady wants to merge 2 commits into
base: main
Choose a base branch
from
+54 −0
Open

ppx/test: cover encode behavior for @drop_default variants #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d0b1cd
ppx/test: cover encode behavior for @drop_default variants
Khady Apr 28, 2026
2563000
ppx/test: cover record-typed @json.default with nested @drop_default
Khady Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ppx/test/example.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ type ('a, 'b) p2 = A of 'a | B of 'b [@@deriving json]
type allow_extra_fields = {a: int} [@@deriving json] [@@json.allow_extra_fields]
type allow_extra_fields2 = A of {a: int} [@json.allow_extra_fields] [@@deriving json]
type drop_default_option = { a: int; b_opt: int option; [@option] [@json.drop_default] } [@@deriving json]
let equal_int = Int.equal
type drop_default_int = { dd_a: int; dd_b: int [@json.default 0] [@json.drop_default] } [@@deriving json]
type drop_default_expr = { dde_a: int; dde_b: int [@json.default 0] [@json.drop_default Int.equal] } [@@deriving json]
type drop_default_if_json_eq = { ddj_a: int; ddj_b: int [@json.default 0] [@json.drop_default_if_json_equal] } [@@deriving json]
type inner_with_option_field = { foo: int option [@option] [@json.drop_default] } [@@deriving json]
let empty_inner_with_option_field : inner_with_option_field = { foo = None }
type outer_default_record_with_option = {
inner: inner_with_option_field; [@json.default empty_inner_with_option_field]
} [@@deriving json]
type array_list = { a: int array; b: int list} [@@deriving json]
type json = Melange_json.t
type of_json = C : string * (json -> 'a) * ('a -> json) * 'a -> of_json
Expand Down Expand Up @@ -74,6 +83,15 @@ let of_json_cases = [
C ({|["A",{"a":1,"b":2}]|}, allow_extra_fields2_of_json, allow_extra_fields2_to_json, A {a=1});
C ({|{"a":1}|}, drop_default_option_of_json, drop_default_option_to_json, {a=1; b_opt=None});
C ({|{"a":1,"b_opt":2}|}, drop_default_option_of_json, drop_default_option_to_json, {a=1; b_opt=Some 2});
C ({|{"dd_a":1}|}, drop_default_int_of_json, drop_default_int_to_json, {dd_a=1; dd_b=0});
C ({|{"dd_a":1,"dd_b":5}|}, drop_default_int_of_json, drop_default_int_to_json, {dd_a=1; dd_b=5});
C ({|{"dde_a":1}|}, drop_default_expr_of_json, drop_default_expr_to_json, {dde_a=1; dde_b=0});
C ({|{"dde_a":1,"dde_b":5}|}, drop_default_expr_of_json, drop_default_expr_to_json, {dde_a=1; dde_b=5});
C ({|{"ddj_a":1}|}, drop_default_if_json_eq_of_json, drop_default_if_json_eq_to_json, {ddj_a=1; ddj_b=0});
C ({|{"ddj_a":1,"ddj_b":5}|}, drop_default_if_json_eq_of_json, drop_default_if_json_eq_to_json, {ddj_a=1; ddj_b=5});
C ({|{"inner":{}}|}, outer_default_record_with_option_of_json, outer_default_record_with_option_to_json, {inner = {foo = None}});
C ({|{"inner":{"foo":5}}|}, outer_default_record_with_option_of_json, outer_default_record_with_option_to_json, {inner = {foo = Some 5}});
C ({|{}|}, outer_default_record_with_option_of_json, outer_default_record_with_option_to_json, {inner = empty_inner_with_option_field});
C ({|{"a":[1],"b":[2]}|}, array_list_of_json, array_list_to_json, {a=[|1|]; b=[2]});
C ({|["Circle", 5.0]|}, shape_of_json, shape_to_json, Circle 5.0);
C ({|["Rectangle", 10.0, 20.0]|}, shape_of_json, shape_to_json, Rectangle (10.0, 20.0));
Expand Down
18 changes: 18 additions & 0 deletions ppx/test/ppx_deriving_json_js.e2e.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,24 @@
JSON REPRINT: {"a":1}
JSON DATA: {"a":1,"b_opt":2}
JSON REPRINT: {"a":1,"b_opt":2}
JSON DATA: {"dd_a":1}
JSON REPRINT: {"dd_a":1}
JSON DATA: {"dd_a":1,"dd_b":5}
JSON REPRINT: {"dd_a":1,"dd_b":5}
JSON DATA: {"dde_a":1}
JSON REPRINT: {"dde_a":1}
JSON DATA: {"dde_a":1,"dde_b":5}
JSON REPRINT: {"dde_a":1,"dde_b":5}
JSON DATA: {"ddj_a":1}
JSON REPRINT: {"ddj_a":1}
JSON DATA: {"ddj_a":1,"ddj_b":5}
JSON REPRINT: {"ddj_a":1,"ddj_b":5}
JSON DATA: {"inner":{}}
JSON REPRINT: {"inner":{}}
JSON DATA: {"inner":{"foo":5}}
JSON REPRINT: {"inner":{"foo":5}}
JSON DATA: {}
JSON REPRINT: {"inner":{}}
JSON DATA: {"a":[1],"b":[2]}
JSON REPRINT: {"a":[1],"b":[2]}
JSON DATA: ["Circle", 5.0]
Expand Down
18 changes: 18 additions & 0 deletions ppx/test/ppx_deriving_json_native.e2e.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,24 @@
JSON REPRINT: {"a":1}
JSON DATA: {"a":1,"b_opt":2}
JSON REPRINT: {"a":1,"b_opt":2}
JSON DATA: {"dd_a":1}
JSON REPRINT: {"dd_a":1}
JSON DATA: {"dd_a":1,"dd_b":5}
JSON REPRINT: {"dd_a":1,"dd_b":5}
JSON DATA: {"dde_a":1}
JSON REPRINT: {"dde_a":1}
JSON DATA: {"dde_a":1,"dde_b":5}
JSON REPRINT: {"dde_a":1,"dde_b":5}
JSON DATA: {"ddj_a":1}
JSON REPRINT: {"ddj_a":1}
JSON DATA: {"ddj_a":1,"ddj_b":5}
JSON REPRINT: {"ddj_a":1,"ddj_b":5}
JSON DATA: {"inner":{}}
JSON REPRINT: {"inner":{}}
JSON DATA: {"inner":{"foo":5}}
JSON REPRINT: {"inner":{"foo":5}}
JSON DATA: {}
JSON REPRINT: {"inner":{}}
JSON DATA: {"a":[1],"b":[2]}
JSON REPRINT: {"a":[1],"b":[2]}
JSON DATA: ["Circle", 5.0]
Expand Down