Merged
Conversation
Contributor
|
If this pr makes the behaviors that my other PR fixed work properly as well (so make profi's tmio driver work for both nand and SD on melon), then I'll close mine. |
This is the assumption that profi's sdmmc driver makes, which follows the SD specs and properly behave on hardware, with this, his nand driver (and by extension the one used by blocksds) properly works
asiekierka
force-pushed
the
feature/sdmmc-fixes
branch
from
74ba264 to
29d1a0a
Compare
Contributor
Author
|
Tested (finally), appears to work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2415 - note that I could not test it at this time, however, so the PR might need some extra work.