Open
Conversation
…look on par, + deletion of unused include. I think that is last thing that was missing from that fork and probably last revision.
SMarioMan
reviewed
Jan 26, 2026
Comment on lines
+2232
to
+2245
| #ifdef _WIN32 | ||
| HWND hwnd = (HWND)winId(); | ||
| LONG style = GetWindowLong(hwnd, GWL_STYLE); | ||
|
|
||
| if (style & WS_CAPTION) { | ||
| style &= ~(WS_CAPTION | WS_THICKFRAME); | ||
| } else { | ||
| style |= WS_CAPTION | WS_THICKFRAME; | ||
| } | ||
|
|
||
| SetWindowLong(hwnd, GWL_STYLE, style); | ||
| SetWindowPos(hwnd, nullptr, 0, 0, 0, 0, | ||
| SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER | SWP_FRAMECHANGED); | ||
| #endif |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
You must have misinterpreted this commit. This one is for windows border, like with minimizing and closing options. You should refer to #2528 which uses code in line with what you are saying. Yeah, I know it is only windows (for now) but it does its job, I could improve it in the future, but there is no need for now. And Sorry for confusion :p
Author
There was a problem hiding this comment.
I just changed the title to more resemble what it really does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This toggle allows users to disable the system title bar and window frame.
It is specifically designed to provide a clean, borderless experience,
which pairs perfectly with #2528 for multi-window setups.
Unlike hiding the Menu Bar, this affects the native OS window
(title bar, close/min/max buttons), allowing the emulator content
to fill the entire window area.