You can keep multiple mappings, for different joystick models, and they won't overwrite each other#2569
Open
vitor251093 wants to merge 16 commits intomelonDS-emu:masterfrom
Open
Conversation
Updating base repository
Updating base branch
Updating base branch
Updating melonDS base
Keeping up to date with melonDS
melonDS 1.0
Master melonDS
Author
|
Tested, and now ready for validation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title implies, with those changes, melonDS now stores the joystick mappings by model, so you can use different controller models without their mappings overwriting each other.
As of this PR, I'm grouping the joystick mappings by a combination of the Vendor ID and the Device ID, which I refer in the code as the "Unique ID". The combination of Vendor ID and Device ID is fine grained enough to differ between a DualShock 4 v1 (0x054c05c4) and a DualShock 4 v2 (0x054c09cc).
I've removed the legacy imports of joystick mappings since the OG
Instance*.Joystickisn't used after this PR.This is still being tested, which is why it's, for now, a draft.