Fix @loader_path find and replace for static builds#2583
Fix @loader_path find and replace for static builds#2583vnescape wants to merge 1 commit intomelonDS-emu:masterfrom
Conversation
|
You didn't actually build a static build if it depends on any non-system dylibs, if you used homebrew for the dependencies then I don't think that will work. |
I compiled it in a VM to isolate my dev environment and then copied it over to another machine to see if it worked. Before that I would need to have the QT libs installed on the machine. Now I can run the application without the QT libs being installed on the target machine. |
|
There shouldn't be any dylibs in the first place in the expected setup for static builds. If you look inside the app bundle you will notice that the Qt libraries are in there, and if that's fine (we build statically linked builds to save file size) you can just build a dynamically linked build and the script should work fine as-is. |
|
I wanted to build a macOS build of melonDS that does not require any external lib to be installed on the target machine.
This will lead to the following error message: This PR tries to fix this problem and be able to build melonDS on macOS using the |
I followed the instructions in BUILD.md on macOS 15.7.4 to build melonDS statically, but it failed. I resolved the issue by respecting the @loader_path that some libraries use for their includes.