Align Hello.sv with the documentation. #915
Open
+16
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation at https://melt.cs.umn.edu/silver/install-guide/#testing-things-out-by-building-the-tutorials claims that the World is upper case (as is expected in most hello-world applications).
Changes
readlink, and the code that was required to maintain different executions per platform. Now the code only depends on abash-ism.Documentation
Testing
Locally, this change affects my silver docker build where I validate that the image is correctly built and things are as expected by utilizing the Hello.sv and expecting the output.
Same docker build process, also is using the install script.
Dependencies
To print the $REPO a new runtime dependency is added to
git- expectation is that git is already available. If this is undesired, printing the root, could be removed anyway.Assumptions
That the install script and the scripts to be installed live in the same directory (same as before).
Quality
There are two
shellcheckwarnings that exist in code I didn't touch, newly added/modified code is shellcheck warning free