Fix: Handle tuple results in get_all method (Issue #3419) #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix AttributeError when vector store returns tuple instead of list - Add robust handling for both ScoredPoint objects and dict-based results - Ensure actual_memories is always a list to prevent iteration over dict keys - Add comprehensive tests for tuple, dict, and single dict result scenarios Resolves: mem0ai#3419
|
|
- Fixed line length issues in aws_bedrock.py method signature - Fixed line length issues in pgvector.py docstring and method calls - Fixed line length issues in valkey.py comments and error messages - Improved code readability by breaking long lines appropriately
Contributor
|
Hey @pxkundu Can you please make sure to resolve conflicts and also it seems the change which you were gonna make has already been implemented. |
Contributor
|
Closing this PR as the bug is fixed and the solution is implemented. Thank you again for implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where tuple results were not being handled properly in the get_all method. The fix ensures that tuple results are correctly processed and returned as expected.