Fix/neo4j cleanup on delete 3245 #3557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement delete() method for Neo4j, Memgraph, Kuzu, and Neptune - Extract entities from deleted memory and decrement mentions counter - Remove orphaned nodes when mention count reaches zero - Add comprehensive tests for graph cleanup with/without graph enabled - Add type hints (tuple[str, dict]) to Neptune _delete_entities_cypher - Ensure memory deletion is security-scoped (user_id/agent_id/run_id) Resolves mem0ai#3245
lsvishaal
force-pushed
the
fix/neo4j-cleanup-on-delete-3245
branch
from
32be873 to
befd3db
Compare
Contributor
Author
|
apologies for the mess! 😓, I squashed the commits into a single clean commit for easier review. |
Contributor
|
Hey @lsvishaal no worries, will get this PR reviewed in some time. Thanks for implementing it |
Contributor
Author
|
Hey @parshvadaftari , any updates? 😁 |
parshvadaftari
suggested changes
Oct 15, 2025
Contributor
parshvadaftari
left a comment
parshvadaftari
left a comment
There was a problem hiding this comment.
Rest looks good to me. Please incorporate the requested changes
tests/test_memory.py
Outdated
| @patch('mem0.utils.factory.VectorStoreFactory.create') | ||
| @patch('mem0.utils.factory.LlmFactory.create') | ||
| @patch('mem0.memory.storage.SQLiteManager') | ||
| def test_delete_memory_calls_graph_cleanup(mock_sqlite, mock_llm_factory, mock_vector_factory, mock_embedder_factory, mock_graph_factory): |
Contributor
There was a problem hiding this comment.
Can you add tests which cover entire end to end graph deletion? and move the graph related tests to separate file?
Contributor
Author
There was a problem hiding this comment.
Done,
Added end to end tests in separate file as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements automatic graph cleanup when memories are deleted, addressing Issue #3245. Previously, when a memory was deleted from the vector store, the associated entities and relationships in the graph database remained as orphaned nodes, leading to data inconsistency and potential memory leaks.
The solution adds a
delete()method to all graph store implementations (Neo4j, Memgraph, Kuzu, and Neptune) that properly cleans up entity relationships by:mentionscounter for each entityThe implementation includes error handling to ensure memory deletion continues even if graph cleanup fails, maintaining system reliability.
Fixes #3245
Type of change
How Has This Been Tested?
Test Coverage:
test_delete_memory_calls_graph_cleanup- Verifies that graph.delete() is called with correct parameters when graph is enabledtest_delete_memory_continues_without_graph- Ensures deletion works when graph is not enabledTest Configuration:
Checklist:
Maintainer Checklist