Skip to content

Feature: tencent vector db integration #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature: tencent vector db integration #3598

wants to merge 1 commit into from

Conversation

@wlleiiwang
Copy link

@wlleiiwang wlleiiwang commented Oct 16, 2025

Description

Integration of TencentVectorDB as a vector store backend. This implementation provides a complete interface for vector operations including insert, search, update, and delete operations, with support for metadata filtering and similarity search.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wlleiiwang wlleiiwang force-pushed the feature/tencent-vectordb branch from e2c7554 to f1521e4 Compare October 16, 2025 13:07
@parshvadaftari
Copy link
Contributor

parshvadaftari commented Oct 16, 2025

Hey @wlleiiwang can you please sign CLA to get things started? Thanks for this integration.

@wlleiiwang wlleiiwang force-pushed the feature/tencent-vectordb branch 6 times, most recently from c1ed000 to 1b9894a Compare October 17, 2025 03:58
parshvadaftari
parshvadaftari suggested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@parshvadaftari parshvadaftari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me, can you please incorporate the requested changes? Thanks for putting this effort for this integration. Also can you please check for the failing tests?

docs/components/vectordbs/dbs/tencent.mdx Outdated
"provider": "tencent",
"config": {
"url": "http://10.0.X.X:80",
"key": "A5VOgsMpGWJhUI0WmUbY********************"
Copy link
Contributor

@parshvadaftari parshvadaftari Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the key we can keep something like "YOUR_TENCENT_KEY".

tests/vector_stores/test_tencent.py Outdated
"""Create TencentVectorDB instance with mocked client."""
return TencentVectorDB(
url="http://127.0.0.1:80",
key="eC4bLRy2va******************************",
Copy link
Contributor

@parshvadaftari parshvadaftari Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the test suite, something like "mock_tencent_api_key"

Copy link
Author

@wlleiiwang wlleiiwang Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your advice. I have implemented the adjustments as discussed.

@wlleiiwang wlleiiwang force-pushed the feature/tencent-vectordb branch 2 times, most recently from 3313067 to 14e962e Compare October 23, 2025 02:25
@wlleiiwang
Copy link
Author

wlleiiwang commented Oct 23, 2025

@parshvadaftari Please help me review the code again.

@parshvadaftari
Copy link
Contributor

parshvadaftari commented Oct 23, 2025

Hey @wlleiiwang the tests are failing please check for it.

@wlleiiwang wlleiiwang force-pushed the feature/tencent-vectordb branch 2 times, most recently from 5786eb5 to 57f6c8d Compare October 26, 2025 16:19
@wlleiiwang
Copy link
Author

wlleiiwang commented Oct 28, 2025

@parshvadaftari Please help me review the code again.

@wlleiiwang wlleiiwang closed this Nov 1, 2025
@wlleiiwang wlleiiwang reopened this Nov 3, 2025
@wlleiiwang wlleiiwang force-pushed the feature/tencent-vectordb branch 2 times, most recently from cc7cf51 to 7ba47a9 Compare November 3, 2025 16:56
@wlleiiwang
Copy link
Author

wlleiiwang commented Nov 3, 2025

Clipboard_Screenshot_1762188311 Clipboard_Screenshot_1762188804

@parshvadaftari Please help me review the code again.

@wlleiiwang wlleiiwang force-pushed the feature/tencent-vectordb branch from 7ba47a9 to 2e89697 Compare November 3, 2025 17:03
@wlleiiwang
Copy link
Author

wlleiiwang commented Nov 4, 2025

@Dev-Khant Please help me review the code

@wlleiiwang wlleiiwang marked this pull request as draft November 5, 2025 04:43
@wlleiiwang wlleiiwang marked this pull request as ready for review November 5, 2025 04:44
@wlleiiwang
Copy link
Author

wlleiiwang commented Nov 18, 2025

@Dev-Khant @parshvadaftari Please help me review the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parshvadaftari parshvadaftari Awaiting requested review from parshvadaftari

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wlleiiwang @CLAassistant @parshvadaftari