fix(redis): cast vector_distance to float to prevent TypeError on threshold search#4298
Open
NIK-TIGER-BILL wants to merge 1 commit intomem0ai:mainfrom
Open
Conversation
…eshold search
redisvl returns vector_distance as a string, not a float. When memory.search()
is called with a threshold parameter, the comparison:
score >= threshold
fails with:
TypeError: '>=' not supported between instances of 'str' and 'float'
Fix: wrap result['vector_distance'] in float() before assigning to score.
Closes mem0ai#4294
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
redisvlreturnsvector_distanceas a string, not a float. Whenmemory.search()is called with athresholdparameter, mem0 compares the score to the threshold:This causes (closes #4294):
Fix
Wrap the
vector_distancevalue infloat()before assigning it toscore:One-line change, no behaviour change for valid distances.