fix(docs): use filters param for search in LiveKit integration#4300
Open
kartik-mem0 wants to merge 1 commit intomainfrom
Open
fix(docs): use filters param for search in LiveKit integration#4300kartik-mem0 wants to merge 1 commit intomainfrom
kartik-mem0 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The LiveKit integration docs use
user_id=RAG_USER_IDas a direct kwarg in thesearch()call. However, the v2 search API (/v2/memories/search/) requiresuser_idinside thefiltersobject it's a required field per theMemorySearchInputV2schema in openapi.json.With the current code,
user_idgets placed at the top level of the payload where the API ignores it, so search silently returns empty results. Users following this guide get a voice agent with no memory recall.Changed to
filters={"user_id": RAG_USER_ID}which matches the v2 API contract and the official code samples.Fixes #3832
Type of change
How Has This Been Tested?
MemorySearchInputV2schema in openapi.json requiresfiltersas a top-level field withuser_idnested insidemem0/client/main.py:252-277— confirmeduser_id=kwarg lands at payload top level, not insidefiltersadd()call usinguser_id=directly is correct (v1 endpoint accepts it at top level)Checklist: