fix(server): clear stale provider api keys#4996
Open
imwyvern wants to merge 1 commit intomem0ai:mainfrom
Open
Conversation
|
|
Author
|
I'll get the CLA signed — will follow up once it's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #4984
Description
Changing the configured provider could leave the previous provider's API key in the runtime config. Persisted overrides are now scrubbed when they switch providers, matching environment variables are applied after database overrides, and the dashboard clears the provider key field when the provider changes.
Added regression coverage for stale database overrides, runtime updates with env keys, dropping the previous provider key, and keeping a newly-entered provider key.
Type of Change
Breaking Changes
N/A
Test Coverage
python3 -m pytest tests/test_server_state.py -qpasses locally.pnpm --dir server/dashboard run typecheckcurrently fails before checking this change because the local install is missing the implicityauzltype definition.Checklist