fix(cli): pass API key via env var instead of argv (closes #4862)#4998
Open
PHclaw wants to merge 1 commit intomem0ai:mainfrom
Open
fix(cli): pass API key via env var instead of argv (closes #4862)#4998PHclaw wants to merge 1 commit intomem0ai:mainfrom
PHclaw wants to merge 1 commit intomem0ai:mainfrom
Conversation
API keys were previously passed to the telemetry subprocess via sys.argv, exposing them through ps, /proc/<pid>/cmdline, and process inspection tools on all platforms. Changes: - telemetry.py: read API key from config and pass via MEM0_API_KEY environment variable in subprocess.Popen env= parameter - telemetry_sender.py: read MEM0_API_KEY from os.environ instead of ctx dict; updated docstring to document the security model - test_telemetry_security.py: add regression tests verifying the API key never appears in subprocess argv and is correctly passed via the environment variable
|
PHclaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Hi maintainers! I'd like to sign the CLA for this PR. Could someone point me to the CLA signing page? The cla-assistant.io link in the bot comment doesn't seem to redirect to the signing form. Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API keys were previously passed to the telemetry subprocess via sys.argv, exposing them through ps, /proc//cmdline, and process inspection tools on all platforms.
Fix: pass the API key via the MEM0_API_KEY environment variable instead.
Changes
elemetry.py
elemetry_sender.py
est_telemetry_security.py (new)
Security impact
Closes #4862