fix(vector-stores): pass custom Weaviate filters#5019
Open
haosenwang1018 wants to merge 1 commit intomem0ai:mainfrom
Open
fix(vector-stores): pass custom Weaviate filters#5019haosenwang1018 wants to merge 1 commit intomem0ai:mainfrom
haosenwang1018 wants to merge 1 commit intomem0ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
user_id,agent_id, andrun_id.search(),keyword_search(), andlist().0while still skippingNone.Fixes #4053.
Note: #4848 was closed in favor of #4853, but #4853 fixed same-key metadata filter merging in
Memory; it does not change the Weaviate vector store whitelist that still drops custom metadata keys.Testing
uv run --with pytest --with pytest-mock --with ruff --with weaviate-client --with python-dotenv python -m pytest tests/vector_stores/test_weaviate.py -quv run --with ruff ruff check mem0/vector_stores/weaviate.py tests/vector_stores/test_weaviate.pyuv run --with ruff ruff format --check mem0/vector_stores/weaviate.py tests/vector_stores/test_weaviate.py