fix: avoid mutating LLM factory config dictionaries - #6430
Open
lntutor wants to merge 1 commit into
Open
Conversation
|
|
lntutor
force-pushed
the
fix/llm-factory-config-mutation-6428
branch
from
July 26, 2026 07:47
fe138fd to
2db3b68
Compare
lntutor
force-pushed
the
fix/llm-factory-config-mutation-6428
branch
from
July 30, 2026 13:22
2db3b68 to
8b8a00d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #6428
Description
LlmFactory.create()now merges keyword overrides into a new dictionary instead of callingupdate()on the caller-owned config. Provider precedence is unchanged, while shared configuration dictionaries remain reusable after factory construction.Type of Change
Breaking Changes
N/A
Test Coverage
hatch run dev_py_3_11:pytest tests/utils/test_factory.py -q: 4 passed.Checklist