fix: preserve latest SQLite messages on timestamp ties - #6431
Open
lntutor wants to merge 1 commit into
Open
Conversation
|
|
lntutor
force-pushed
the
fix/sqlite-message-order-6429
branch
from
July 26, 2026 06:07
4a8669d to
01432ad
Compare
lntutor
force-pushed
the
fix/sqlite-message-order-6429
branch
from
July 30, 2026 13:22
01432ad to
609bfa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #6429
Description
Messages saved in one batch share a timestamp. SQLite retention and retrieval now use
rowidas a deterministic insertion-order tie-breaker, so batches over ten entries discard the oldest messages andget_last_messages()returns the latest entries chronologically.Type of Change
Breaking Changes
N/A
Test Coverage
hatch run dev_py_3_11:pytest tests/memory/test_storage.py -q: 17 passed.Checklist