fix(storage): add missing lock to SQLiteManager.close() - #6620
Open
bennyyuan1008 wants to merge 1 commit into
Open
fix(storage): add missing lock to SQLiteManager.close()#6620bennyyuan1008 wants to merge 1 commit into
bennyyuan1008 wants to merge 1 commit into
Conversation
close() was the only public method on SQLiteManager that did not acquire self._lock before touching self.connection. Under concurrency, a close() call from one thread while another was mid-transaction could cause AttributeError on NoneType connection, and the cascading ROLLBACK failure would mask the original error. The same risk existed from __del__ which also called close() without the lock. Fixed by wrapping the body in with self._lock.
bennyyuan1008
force-pushed
the
fix/sqlite-close-lock
branch
from
July 27, 2026 05:56
715b175 to
79c9104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #6619
Description
SQLiteManager.close() was the only public method that did not acquire self._lock before touching self.connection. Under concurrency, a concurrent close() while another thread is mid-transaction can crash with AttributeError on NoneType connection, and the cascading ROLLBACK failure masks the original error.
The same risk exists via del which calls close() without the lock.
Fix: Add
with self._lock:to close().Type of Change
Test Coverage
Checklist