Add option to enable (or disable) report issue feature.#354
Open
Ostpopcorn wants to merge 20 commits into
Open
Add option to enable (or disable) report issue feature.#354Ostpopcorn wants to merge 20 commits into
Ostpopcorn wants to merge 20 commits into
Conversation
Ostpopcorn
changed the title
…ing_correction_and_readme fix: Spelling & new Swedish makerspace
…p_bypass_RFID Enable signup without entering RFID card
…n_for_last_seen feat: Last seen optional
Ostpopcorn
force-pushed
the
option-enable-report-issue
branch
from
0d6d11a to
bb7f8e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some makerspaces do not use the built-in report issue feature and rely on other methods to communicate issues. Therefore, it would be good to have an option to turn this feature off. This PR adds the ENABLE_REPORT_ISSUE option to facilitate this. The option defaults to true in Constance.
Additionally, in src-frontend/src/pages/Dashboard.vue, the logic is patched to remove the Quick Cards header when no card is enabled. The visibility is governed by a new function, hasVisibleCards().
As mentioned in #351, we in Linköping use Slack for reporting issues and would prefer to have the option to remove it.
As with my other PR(#353), I have very little web development experience and rely on Claude to write the code. I have checked all edits to ensure they are logical and sound. The code has been tested locally and produces the expected results.