Skip to content

Only search packages that have hexdocs - #1030

Merged
Noarkhh merged 3 commits into
masterfrom
fix-search-packages
Nov 20, 2025
Merged

Only search packages that have hexdocs#1030
Noarkhh merged 3 commits into
masterfrom
fix-search-packages

Conversation

@Noarkhh

@Noarkhh Noarkhh commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Noarkhh Noarkhh self-assigned this Nov 19, 2025
@Noarkhh
Noarkhh requested a review from mat-hek as a code owner November 19, 2025 15:54
@Noarkhh Noarkhh added this to Smackore Nov 19, 2025
@Noarkhh Noarkhh moved this to In Review in Smackore Nov 19, 2025
@Noarkhh Noarkhh added the no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md label Nov 19, 2025
Comment thread scripts/elixir/update_packages_list.exs Outdated
|> Enum.filter(&(&1.type == :package and &1.hexdocs_badge != nil))
|> Enum.map(&String.to_atom(&1.name))

File.write(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
File.write(
File.write!(

And prepend a comment saying to not edit as it's auto-generated by packages.exs

@Noarkhh
Noarkhh force-pushed the fix-search-packages branch from 40034b1 to 30805fa Compare November 20, 2025 09:56
@Noarkhh
Noarkhh force-pushed the fix-search-packages branch from 30805fa to 806a22c Compare November 20, 2025 11:50
@Noarkhh
Noarkhh requested a review from mat-hek November 20, 2025 15:21
Comment on lines 180 to +181
generated_code_comment =
"<!-- Generated code, do not edit. See `scripts/elixir/update_packages_list.exs`. -->"
"<!-- #{generated_code_comment} -->"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not reassign the variable, just add the markers in line 209

@Noarkhh
Noarkhh merged commit c96997c into master Nov 20, 2025
5 of 6 checks passed
@Noarkhh
Noarkhh deleted the fix-search-packages branch November 20, 2025 16:27
@github-project-automation github-project-automation Bot moved this from In Review to Done in Smackore Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This label has to be added if changes from the PR are not meant to be placed in the CHANGELOG.md

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants