Skip to content

Avoid division by 0 in stalker under weird timer behaviour - #1035

Merged
mat-hek merged 3 commits into
masterfrom
mf/workaround-stalker-arithmetic-error
Dec 19, 2025
Merged

Avoid division by 0 in stalker under weird timer behaviour#1035
mat-hek merged 3 commits into
masterfrom
mf/workaround-stalker-arithmetic-error

Conversation

@mat-hek

@mat-hek mat-hek commented Dec 4, 2025

Copy link
Copy Markdown
Member

No description provided.

@mat-hek
mat-hek requested a review from FelonEkonom December 4, 2025 11:35
@mat-hek mat-hek self-assigned this Dec 4, 2025
@mat-hek mat-hek added this to Smackore Dec 4, 2025
@mat-hek mat-hek moved this to In Review in Smackore Dec 4, 2025

@FelonEkonom FelonEkonom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention in the log message that such a behaviour might be caused by long running NIFs executed on normal schedulers.
Let's also bump patch in version and release it.

BTW IMO this will fix this error in YOLO demo: membraneframework/membrane_camera_capture_plugin#25

@mat-hek

mat-hek commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

@FelonEkonom before we merge, please try running the demo with the fix a few times

@FelonEkonom

Copy link
Copy Markdown
Member

I have run it and timeout on opening the camera doesn't cause any logs about Stalker crash.

@mat-hek mat-hek changed the title Workaround for a werid bug leading to division by 0 in stalker Fix division by 0 in stalker under weird timer behaviour Dec 12, 2025
@mat-hek mat-hek changed the title Fix division by 0 in stalker under weird timer behaviour Avoid division by 0 in stalker under weird timer behaviour Dec 12, 2025
@mat-hek
mat-hek force-pushed the mf/workaround-stalker-arithmetic-error branch from 1d7c7fc to c1057c4 Compare December 19, 2025 09:31
@mat-hek
mat-hek merged commit 87c3457 into master Dec 19, 2025
5 of 6 checks passed
@mat-hek
mat-hek deleted the mf/workaround-stalker-arithmetic-error branch December 19, 2025 09:36
@github-project-automation github-project-automation Bot moved this from In Review to Done in Smackore Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants