Skip to content

Refine logs for when linking elements fails #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kidq330 merged 4 commits into from
Aug 3, 2026
Merged

Refine logs for when linking elements fails #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
378fb22
Refine logs for when linking elements fails
kidq330 Jul 15, 2026
a10ba6d
Update changelog
kidq330 Jul 23, 2026
6c9e55b
mix format
kidq330 Jul 23, 2026
0ae7239
Merge branch 'master' into kidq330/link-call-timeout
kidq330 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.3.5
* Make logs more specific about the reason when linking elements fails [#1167](https://github.com/membraneframework/membrane_core/pull/1167)

## 1.3.0
* Make errors more descriptive [#1102](https://github.com/membraneframework/membrane_core/pull/1102)
* Add `:broadcast` action for sending data to all output pads of an element
Expand Down
15 changes: 15 additions & 0 deletions lib/membrane/core/parent/child_life_controller/link_utils.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,21 @@ defmodule Membrane.Core.Parent.ChildLifeController.LinkUtils do
state
end

defp log_handle_link_error({:call_failure, {:timeout, _reason}}, from, to) do
Membrane.Logger.warning("""
Failed to establish link between #{inspect(from.child)} via #{inspect(from.pad_ref)} and
#{inspect(to.child)} via #{inspect(to.pad_ref)} because #{inspect(from.child)} took too long to link.
""")
end

defp log_handle_link_error({:call_failure, {{exception, _stack}, _reason}}, from, to)
when is_exception(exception) do
Membrane.Logger.debug("""
Failed to establish link between #{inspect(from.child)} via #{inspect(from.pad_ref)} and
#{inspect(to.child)} via #{inspect(to.pad_ref)} because #{inspect(from.child)} failed with an exception.
""")
end

defp log_handle_link_error({:call_failure, _reason}, from, to) do
Membrane.Logger.debug("""
Failed to establish link between #{inspect(from.child)} via #{inspect(from.pad_ref)} and
Expand Down
Loading