Mulaw #9
Open
Mulaw #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
requested changes
May 5, 2025
lib/membrane_g711_ffmpeg/decoder.ex
Outdated
Comment on lines
59
to
62
| case stream_format do | ||
| %G711{encoding: encoding} -> encoding | ||
| %RemoteStream{} -> state.encoding | ||
| end |
There was a problem hiding this comment.
I am not sure if we should accept setting encoding: :PCMU and then override it within handle_stream format.
Perhaps we should also allow for nil :encoding?
| @@ -14,9 +14,16 @@ defmodule Membrane.G711.FFmpeg.Decoder do | |||
| alias Membrane.G711.FFmpeg.Common | |||
| alias Membrane.{G711, RawAudio, RemoteStream} | |||
|
|
|||
| def_options encoding: [ | |||
There was a problem hiding this comment.
[NIT] I think the name used to describe PCMA and PCMU is companding algorithm, but I am fine with encoding as well :D
There was a problem hiding this comment.
We already have 'encoding' in the g711 format, so let's leave it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.