fix stsz box, improve conditional fields handling #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
commented
Jan 8, 2025
Comment on lines
+255
to
+256
| if sample_sizes != [] and Enum.all?(sample_sizes) == hd(sample_sizes) do | ||
| %{sample_size: hd(sample_sizes), entry_list: []} |
Member
Author
There was a problem hiding this comment.
apparently we don't have a fixture to test this
varsill
reviewed
Jan 9, 2025
varsill
approved these changes
Jan 10, 2025
Contributor
varsill
left a comment
varsill
left a comment
There was a problem hiding this comment.
As discussed, the handle_when approach with serialization will be added in separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stszparsing and serializationwhenis absent in the context