Allow to receive raw RTP in Sink / Allow to negotiate AV1 codecs #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
requested changes
Dec 12, 2025
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good, but setting depayload: false in the sink options should make it work without special-casing. You can just make sure that the error is meaningful if somebody doesn't set it and AV1 comes in. Also, please add a symmetric change in the source and at least one integration test.
maslowalex
force-pushed
the
allow-raw-rtp-in-sink
branch
from
e649a61 to
f615782
Compare
maslowalex
force-pushed
the
allow-raw-rtp-in-sink
branch
from
f615782 to
3447f2b
Compare
Member
|
@maslowalex can you please rebase your branch? We fixed the CI on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the ability to receive the raw RTP packets (AV1) in our pipelie, which will allow to bypass everything else, including the payloading.
This code solves the problem for us, so we decided to raise a PR.
Please let me know what I should improve. Thank you in advance, Olexandr.