You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR automates the build process for every device specified in manifest.xml and handles the deployment to GitHub Releases.
While users currently have the option to sideload these packages manually, hosting them on the official Connect IQ Store would provide a much better user experience. Could you please add support for the latest devices and handle the official marketplace submission?
Thank you for this pull request! Automating the building process looks good, although relying on a third party to keep the Garmin sdk files up to date. Some questions I have:
What is the idea behind the developer key? It seems like the key is generated for each build.
The action is now triggered by a push. Is that desired or should it be triggered on a version release? How computationally intensive is the build for 60+ devices?
The update I am finalizing is unfortunately slightly different in structure than the last version in this SubMusic repository. The APIs and sync modules are separated and I have to think about how to combine this pull request with that multi-repo structure.
I just used a generated key to prove the CI works. You can definitely switch to an encrypted static key using GitHub Secrets later. Check out this workflow blackshadev/wayfinder/.github/workflows/garmin.yml#L11 for a good example of how to handle that.
The action is trigger by a push right now for easy testing, but it can be changed to trigger on releases instead. It’s pretty fast, it only takes about 2 minutes to build for all 67 devices. You can see the action logs here: github.com/cristianpb/SubMusic/actions/runs/21743352322
I noticed the shift in development toward Submusic for Plex, which uses a different configuration. However, since this repository has been inactive for two years, my primary goal was simply to bring the app up to date for newer devices. If you're looking into a multi-repo approach, this example https://github.com/blackshadev/wayfinder/blob/main/.github/workflows/server.yml shows a great way to manage a proxy server and the CI app simultaneously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR automates the build process for every device specified in manifest.xml and handles the deployment to GitHub Releases.
While users currently have the option to sideload these packages manually, hosting them on the official Connect IQ Store would provide a much better user experience. Could you please add support for the latest devices and handle the official marketplace submission?