feat: Rebuild cmake#102
Draft
biggerfisch wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
biggerfisch
changed the base branch from
avery/06-24-feat_upgrade_gdb-xtensa-esp32_to_16.2
to
graphite-base/102
biggerfisch
force-pushed
the
avery/01-07-feat_rebuild_cmake
branch
from
f0fafdb to
40f4489
Compare
biggerfisch
force-pushed
the
graphite-base/102
branch
from
0b5bf58 to
16599a8
Compare
biggerfisch
force-pushed
the
avery/01-07-feat_rebuild_cmake
branch
from
40f4489 to
e3b3c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm not sure if this is a needed change, but this allows
cmaketo depend onzlib 1.3. I'm not actually sure it needszlibat all however, but I don'twanna do that rabbit hole atm.
Doesn't bump anything except min things required to build on a modern env.
Test Plan
osx-arm64