Skip to content

Fix release job#7

Merged
noahp merged 1 commit into
mainfrom
noahp/release-job-not-working
Nov 7, 2025
Merged

Fix release job#7
noahp merged 1 commit into
mainfrom
noahp/release-job-not-working

Conversation

@noahp

@noahp noahp commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@noahp noahp force-pushed the noahp/release-job-not-working branch from 73d7497 to 3fd659e Compare November 7, 2025 21:47
@noahp noahp marked this pull request as ready for review November 7, 2025 22:00
Copilot AI review requested due to automatic review settings November 7, 2025 22:01
@noahp noahp merged commit 074123b into main Nov 7, 2025
8 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the GitHub Actions release workflow to re-package downloaded artifacts before creating a GitHub release. The changes address a mismatch between the artifact structure downloaded from previous build jobs and the expected format for the release.

Key changes:

  • Downgraded actions/download-artifact from v6 to v4
  • Added a new step to re-zip downloaded artifacts into the release-pack directory
  • Updated the release creation command to use the newly created zip files from release-pack
  • Removed the checkout step which was unnecessary for the release job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +119 to +122
for dir in ./artifacts/*; do
BOARD_NAME=$(basename "$dir")
zip -r ./release-pack/${BOARD_NAME}.zip "$dir"
done

Copilot AI Nov 7, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell script lacks error handling. If ./artifacts is empty or contains non-directory files, the loop may fail silently or produce unexpected results. Consider adding a check to verify that ./artifacts/* expands to actual directories before processing, or use a glob pattern that only matches directories.

Suggested change
for dir in ./artifacts/*; do
BOARD_NAME=$(basename "$dir")
zip -r ./release-pack/${BOARD_NAME}.zip "$dir"
done
shopt -s nullglob
for dir in ./artifacts/*/; do
if [ -d "$dir" ]; then
BOARD_NAME=$(basename "$dir")
zip -r ./release-pack/${BOARD_NAME}.zip "$dir"
fi
done
shopt -u nullglob

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants