fix(desktop): bundle slim Windows GStreamer runtime#468
Draft
HoneyBBQ wants to merge 5 commits into
Draft
Conversation
Bundle the display GStreamer runtime for Windows desktop packages and prune its DLL closure so packaged builds do not depend on a system install.
Cache the prepared desktop GStreamer runtime per runner OS so Windows CI avoids repeated slow downloads after the first successful build.
Use the Inno Setup silent installer flags for the Windows GStreamer runtime so CI and package builds can prepare the bundled runtime without showing the interactive wizard.
Treat bundled Windows gst-launch paths as executable without Unix mode bits and remove unused GStreamer development libraries from the packaged runtime.
Hide Windows console windows for desktop-managed Qdrant, local server, and GStreamer processes without changing logging or process lifecycle handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
node --check apps/desktop/scripts/prepare-gstreamer.mjsnode --check apps/desktop/scripts/build.mjsnode apps/desktop/scripts/prepare-gstreamer.mjs --targets=noneNotes