Skip to content

(fix/charts): Give configmap correct name #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(fix/charts): Give configmap correct name #734

wants to merge 1 commit into from

Conversation

sichapman
Copy link

@sichapman sichapman commented Jul 29, 2025 •
edited by coderabbitai bot
Loading

The configmap name should reflect the full deployed chart name, matching other templated objects e.g the pvc and deployment. In a namespace with many charts deployed, it is otherwise not easily identifiable as from renovate

Summary by CodeRabbit

  • Refactor
    • Updated naming conventions for ConfigMap resources and labels in Helm charts to use standardized helper functions, ensuring consistency across deployments.
    • Adjusted volume references in deployment templates to align with the new naming scheme.

No changes to functionality or user-facing features.

@sichapman sichapman requested a review from a team as a code owner July 29, 2025 18:00
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 29, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes update Helm chart templates for both the Community Edition (CE) and Enterprise Edition (EE) of Mend Renovate. Specifically, the ConfigMap resource names and the app.kubernetes.io/name label values in the configmap.yaml templates are modified to use Helm template helper functions (include "mend-renovate.fullname" and include "mend-renovate.name") instead of directly referencing .Release.Name. Corresponding references to these ConfigMaps in deployment templates (deployment.yaml and worker-deployment.yaml) are also updated to align with the new naming convention. No logic, error handling, or public API changes are introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Complexity: Simple
  • Rationale: The changes are limited to Helm template variable substitutions and do not introduce new logic or affect control flow. Review primarily involves verifying correct usage of helper functions and consistency across resource references.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b140edc and e71c234.

📒 Files selected for processing (4)
  • helm-charts/mend-renovate-ce/templates/configmap.yaml (1 hunks)
  • helm-charts/mend-renovate-ce/templates/deployment.yaml (1 hunks)
  • helm-charts/mend-renovate-ee/templates/configmap.yaml (1 hunks)
  • helm-charts/mend-renovate-ee/templates/worker-deployment.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • helm-charts/mend-renovate-ee/templates/worker-deployment.yaml
  • helm-charts/mend-renovate-ce/templates/deployment.yaml
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit Configuration File

**/*: - Feedback will only be given on issues that could cause bugs or involve very bad practices.

  • Comments will be kept concise and focused on critical areas.

Files:

  • helm-charts/mend-renovate-ce/templates/configmap.yaml
  • helm-charts/mend-renovate-ee/templates/configmap.yaml
🪛 YAMLlint (1.37.1)
helm-charts/mend-renovate-ce/templates/configmap.yaml

[error] 4-4: syntax error: expected , but found ''

(syntax)

helm-charts/mend-renovate-ee/templates/configmap.yaml

[error] 4-4: syntax error: expected , but found ''

(syntax)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WhiteSource Security Check
🔇 Additional comments (2)
helm-charts/mend-renovate-ce/templates/configmap.yaml (1)

4-8: Consistent Helm helper usage – looks good

Adopting the include "mend-renovate.fullname" / include "mend-renovate.name" helpers brings this ConfigMap in line with the rest of the chart and avoids clashes when multiple releases share a namespace. Indentation and templating syntax are valid; the YAML-lint error appears to be a false positive from a Helm-unaware linter.

If your CI linter still fails, ensure it runs in “Helm-template” mode or exclude rendered templates from plain YAML checks.

helm-charts/mend-renovate-ee/templates/configmap.yaml (1)

4-8: EE chart aligned with CE – change approved

Same comment as for CE: helper functions prevent name collisions and keep labels uniform. Templating and indentation are correct; any YAML-lint complaints are likely Helm-related false positives.

Verify that downstream manifests referencing this ConfigMap (e.g., worker-deployment) were updated accordingly; search for the old .Release.Name pattern to ensure nothing was missed.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sichapman
Give configmap correct name
e71c234 
If deploying the chart under a helm alias,
the configmap name should reflect that,
like other objects e.g the pvc and
deployment
@sichapman sichapman force-pushed the fix/dynamicconfigjs branch from b140edc to e71c234 Compare July 31, 2025 08:10
@sichapman sichapman changed the title Give configmap correct name (fix/charts): Give configmap correct name Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

+1 more reviewer

@Twinadomumma Twinadomumma Twinadomumma approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sichapman @Twinadomumma