fix: allow custom labels on services

[nabeelsaabna]

Summary by CodeRabbit

• New Features

  • Support for custom service labels in Helm charts for both Community and Enterprise editions.

• Chores

  • Chart version bumps: Community edition to 12.0.2 and Enterprise edition to 6.0.3.
  • Values updated to include an empty service.labels map by default.

[coderabbitai]

📝 Walkthrough

Walkthrough

Bumps chart versions: mend-renovate-ce Chart.yaml 12.0.1 → 12.0.2 and mend-renovate-ee Chart.yaml 6.0.2 → 6.0.3. Adds an optional service-level labels block to the Service templates (CE: templates/service.yaml; EE: templates/server-svc.yaml) that renders .Values.service.labels when present. Adds empty service.labels: {} entries to both charts' values.yaml files. No changes to app behavior or exported/public APIs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Check YAML indentation and Helm with/conditional rendering in:
  • helm-charts/mend-renovate-ce/templates/service.yaml
  • helm-charts/mend-renovate-ee/templates/server-svc.yaml
• Verify the new service.labels entries in both values.yaml files are correctly placed and documented.
• Quick review of Chart.yaml version bumps for correctness.

Possibly related PRs

• fix: bump Chart.yaml #600 — Also modifies Chart.yaml versions for the same charts (related versioning change).

Suggested reviewers

• Gabriel-Ladzaretti

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: enabling custom labels on Kubernetes services across multiple Helm charts by adding service.labels configuration support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ns/fix-service-labels

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17d12ca and 56e76e2.

📒 Files selected for processing (4)

• helm-charts/mend-renovate-ce/templates/service.yaml (1 hunks)
• helm-charts/mend-renovate-ce/values.yaml (1 hunks)
• helm-charts/mend-renovate-ee/templates/server-svc.yaml (1 hunks)
• helm-charts/mend-renovate-ee/values.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• helm-charts/mend-renovate-ce/values.yaml
• helm-charts/mend-renovate-ee/values.yaml

🧰 Additional context used

📓 Path-based instructions (1)

**/*

⚙️ CodeRabbit configuration file

**/*: - Feedback will only be given on issues that could cause bugs or involve very bad practices.

• Comments will be kept concise and focused on critical areas.

Files:

• helm-charts/mend-renovate-ee/templates/server-svc.yaml
• helm-charts/mend-renovate-ce/templates/service.yaml

🪛 YAMLlint (1.37.1)

helm-charts/mend-renovate-ce/templates/service.yaml

[error] 12-12: syntax error: could not find expected ':'

(syntax)

🔇 Additional comments (2)

helm-charts/mend-renovate-ce/templates/service.yaml (1)

11-13: YAMLlint error is a false positive; Helm template syntax is correct.

The YAMLlint error ("could not find expected ':'") occurs because YAMLlint parses the template file as raw YAML before Helm rendering, so it doesn't understand Helm directives (toYaml, nindent). This pattern is standard Helm practice and will render to valid YAML at runtime.

The nindent 4 indentation is correct—custom labels will align with existing labels (both at 4-space indentation from the labels: key).

helm-charts/mend-renovate-ee/templates/server-svc.yaml (1)

11-13: YAMLlint error is a false positive; Helm template syntax is correct and consistent with CE chart.

Same as the CE chart: YAMLlint doesn't understand Helm directives (toYaml, nindent) when parsing the raw template file, so this is a false positive. The pattern is standard Helm practice.

The nindent 4 indentation is correct—custom labels align with existing labels in metadata.labels. The implementation mirrors the CE chart changes, ensuring consistency across both Helm charts.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}