fix: let review app trigger handle skipped pipelines to increase chances of a successful preview launch - #469
Open
mzedel wants to merge 1 commit into
Open
Conversation
…ces of a successful preview launch Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to handle situations as: mendersoftware/mender-server#1974 (comment) - where the pipeline returned is a skipped pipeline. There's still a chance of the wrong pipeline getting picked if a branch is pushed frequently and the bot is triggered shortly after the push, but IMO that's acceptable...