Prevent release please pr creating useless pipelines - #484
Open
oldgiova wants to merge 3 commits into
Open
Conversation
Both are needed to report a commit status without running a pipeline and to inspect the diff between two explicit revisions. No caller yet; this commit is plumbing only. Ticket: QA-1732 Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
A pull request opened by the release bot whose diff is confined to changelog files and the release-please manifest contains nothing a pipeline can test: its tree is the target branch's tree plus those files. Ticket: QA-1732 Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
Every push to a default branch runs the changelog job, which force-pushes the release-please pull request branch. The bot mirrors that to pr_<N> and creates a pipeline that re-runs work the default branch already did. Skip pipeline creation for those pull requests and post a success ci/gitlab status directly, so they still merge on maintainer approval alone. The author is read from pull_request.user rather than sender, since the sender of a synchronize event is whoever pushed. The diff is taken between the base and head SHAs of the event rather than from the pull request's implicit current head, so a concurrent push cannot make the check describe a different commit than the one being marked. Any unmet condition, any API error, and any failure to post the status falls through to creating the pipeline as before. Ticket: QA-1732 Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
oldgiova
force-pushed
the
QA-1732-prevent-release-please-pr-pipelines
branch
from
August 26, 2026 06:00
d99eb1c to
1dd0c50
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release-please PR only changes a CHANGELOG.md and a .release-please-manifest.json file so it's usually useless to run the usual full build/test pipeline for it. What is worse is that every main/master changes are refreshing the PR.
With this change the integration-test-runner is not creating a pipeline when creating/updating a release-please PR, but it's still updating the required github status
Co-authored-with: Claude