-
Notifications
You must be signed in to change notification settings - Fork 737
[UFC-1588] [UFC-1182] Deprecate dojo and set the react client as the default #9520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
[UFC-1588] [UFC-1182] Deprecate dojo and set the react client as the default #9520
Conversation
@@ -28,10 +28,12 @@ These settings influence the behavior of the Runtime when running your applicati | |||
|
|||
### Use React Client {#react-client} | |||
|
|||
This setting enables the new React version of the Mendix Client. There are three options: | |||
This setting enables the React version of the Mendix Client. In Mendix 11.0 and above, the React Client is the default for new applications and the legacy Dojo Client is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the version from "As of Mendix 11" to "In Mendix 11.0 and above". Is that a good change (more precise), or with APIs is it more appropriate to stick to only major versions (e.g. "As of Mendix 11)? @MarkvanMents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change is fine, Connor.
Also makes it less likely that we miss it when we move to Mendix 12.
It requires technical review. |
@@ -100,6 +109,68 @@ In *theme/web/index.html* do the following: | |||
|
|||
Lastly, ensure you are not using any external fonts by checking your theme's styling to confirm all of the fonts are loaded locally. | |||
|
|||
#### In React Client | |||
|
|||
{{% alert color="info" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed since you already mention Dojo is deprecated.
@@ -33,6 +33,12 @@ To upgrade your theme directory to latest version, complete the following steps: | |||
|
|||
### Changing the Theme | |||
|
|||
#### In Dojo Client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we put React client first? Since it's the default and all 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point :)
<html> | ||
<body> | ||
... | ||
<div id-"content"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo here, and for React client this needs to be id="root"
@@ -33,6 +33,8 @@ To upgrade your theme directory to latest version, complete the following steps: | |||
|
|||
### Changing the Theme | |||
|
|||
##### In Dojo Client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments for this file 😄
No description provided.