-
Notifications
You must be signed in to change notification settings - Fork 17
Change test framework from Detox to Maestro #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c882d2a
to
b1478f0
Compare
karahanharunn
previously approved these changes
Feb 11, 2025
d2a2c04
to
ae82a56
Compare
42c493a
to
6f5e45a
Compare
2c92f48
to
a082265
Compare
packages/pluggableWidgets/activity-indicator-native/e2e/specs/maestro/ActivityIndicator.yaml
Outdated
Show resolved
Hide resolved
6bfeb8f
to
3057dab
Compare
3057dab
to
8a6402e
Compare
UrazAkgultan
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed a few unnecessary commented-out lines in some places and left comments about them. Other than that, everything seems fine. Nice work 👍
packages/pluggableWidgets/feedback-native/e2e/specs/maestro/Feedback.yaml
Outdated
Show resolved
Hide resolved
...s/pluggableWidgets/floating-action-button-native/e2e/specs/maestro/FloatingActionButton.yaml
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/image-native/e2e/specs/maestro/Image_url.yaml
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/line-chart-native/e2e/specs/maestro/LineChart.yaml
Outdated
Show resolved
Hide resolved
e36f968
to
891a4d4
Compare
891a4d4
to
d50dbb1
Compare
UrazAkgultan
approved these changes
Mar 5, 2025
vadymv-mendix
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.