Skip to content

[MOO-1015]: Fix Map widget flickers continuously on Android #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/maps-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue where non interactive map was flickering on Android platform

## [5.1.0] - 2024-12-3

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/maps-native/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "maps-native",
"widgetName": "Maps",
"version": "5.1.0",
"version": "5.1.1",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/maps-native/src/Maps.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
minZoomLevel: number;
}

const enum Status {

Check warning on line 24 in packages/pluggableWidgets/maps-native/src/Maps.tsx

View workflow job for this annotation

GitHub Actions / Unit tests

'Status' is defined but never used. Allowed unused vars must match /createElement/u
LoadingMarkers = "loadingMarkers",

Check warning on line 25 in packages/pluggableWidgets/maps-native/src/Maps.tsx

View workflow job for this annotation

GitHub Actions / Unit tests

'LoadingMarkers' is defined but never used. Allowed unused vars must match /createElement/u
LoadingMap = "loadingMap",

Check warning on line 26 in packages/pluggableWidgets/maps-native/src/Maps.tsx

View workflow job for this annotation

GitHub Actions / Unit tests

'LoadingMap' is defined but never used. Allowed unused vars must match /createElement/u
MapReady = "mapReady",

Check warning on line 27 in packages/pluggableWidgets/maps-native/src/Maps.tsx

View workflow job for this annotation

GitHub Actions / Unit tests

'MapReady' is defined but never used. Allowed unused vars must match /createElement/u
CameraAlmostReady = "cameraAlmostReady",

Check warning on line 28 in packages/pluggableWidgets/maps-native/src/Maps.tsx

View workflow job for this annotation

GitHub Actions / Unit tests

'CameraAlmostReady' is defined but never used. Allowed unused vars must match /createElement/u
CameraReady = "cameraReady"

Check warning on line 29 in packages/pluggableWidgets/maps-native/src/Maps.tsx

View workflow job for this annotation

GitHub Actions / Unit tests

'CameraReady' is defined but never used. Allowed unused vars must match /createElement/u
}

interface Marker {
Expand Down Expand Up @@ -88,7 +88,7 @@
zoomEnabled={this.props.interactive}
style={{ flex: 1, alignSelf: "stretch" }}
liteMode={!this.props.interactive}
cacheEnabled={!this.props.interactive}
cacheEnabled={false}
showsPointsOfInterest={false}
mapPadding={{ top: 48, right: 48, bottom: 48, left: 48 }}
onMapReady={this.onMapReadyHandler}
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/maps-native/src/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Maps" version="5.1.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Maps" version="5.1.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Maps.xml" />
</widgetFiles>
Expand Down
Loading