Skip to content

[WTF-2132] Generate types for actions with action variables #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025

Conversation

mlaponder
Copy link
Collaborator

@mlaponder mlaponder commented Feb 10, 2025

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ❌
  • Compatible with: MX 7️⃣, 8️⃣, 9️⃣
  • Did you update version and changelog? ✅ ❌
  • PR title properly formatted ([XX-000]: description)? ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

With Mendix 10.21 it will be possible to pass primitive values to actions. This PR makes sure typing are generated accordingly

Bonus fix included needed for ci is the updating of the deprecated action/cache dependency (see actions/cache#1510)
...

Relevant changes

Type genration will now consider ActionVariables in the XML to generate the typings for action properties.

What should be covered while testing?

...

@mlaponder mlaponder force-pushed the wtf/action-variables-type-generation branch from db23808 to 0fca5f6 Compare March 6, 2025 08:00
@mlaponder mlaponder marked this pull request as ready for review March 6, 2025 09:23
@mlaponder mlaponder requested a review from a team as a code owner March 6, 2025 09:23
Copy link
Contributor

@weirdwater weirdwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to update the version in the release note

@mlaponder mlaponder force-pushed the wtf/action-variables-type-generation branch from b710c53 to e10b18e Compare March 6, 2025 09:31
@weirdwater weirdwater force-pushed the wtf/action-variables-type-generation branch from e10b18e to 69a7843 Compare March 26, 2025 15:14
@alihcsumer alihcsumer merged commit 1de17a7 into master Mar 27, 2025
10 of 13 checks passed
@alihcsumer alihcsumer deleted the wtf/action-variables-type-generation branch March 27, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants