Add conversation readme #136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjchen01
reviewed
Sep 17, 2025
Comment on lines
+82
to
+89
| func GetSystemEnv(c *gin.Context) { | ||
| if strings.HasPrefix(config.Version, "dev") { | ||
| environment_variables.EnvironmentVariables.LoadFromEnv() | ||
| c.JSON(http.StatusOK, environment_variables.EnvironmentVariables) | ||
| } else { | ||
| c.JSON(http.StatusOK, gin.H{}) | ||
| } | ||
| } |
jjchen01
approved these changes
Sep 17, 2025
Comment on lines
+182
to
+183
| func (s *ConversationService) AddItemWithID(ctx context.Context, conversation *Conversation, userID uint, itemType ItemType, role *ItemRole, content []Content, customPublicID string) (*Item, *common.Error) { | ||
| // Check access permissions |
There was a problem hiding this comment.
Consider refactoring this function next time. The arguments are growing, and we have to change the signature every time. Maybe just (ctx context.Context, item *conversation.Item). Items with a conversation ID can fulfill the task.
Comment on lines
+108
to
+116
| POST /v1/chat/completions | ||
| { | ||
| "model": "jan-v1-4b", | ||
| "messages": [ | ||
| {"role": "user", "content": "What's the weather like?"} | ||
| ], | ||
| "conversation": "conv_uzaxr1z1mq38k23r99kl1qq9eelobeam0gw21n8q9z", | ||
| "stream": false | ||
| } |
There was a problem hiding this comment.
Can you test it with the current version of Jan client to see if it is compatible?
There was a problem hiding this comment.
yes, I checked with current version of Jan web as well.
|
Close, I have another PR to replace this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that item id have to generated
Add the conversation flows
// TODO
Discuss to handle dev tricks