Chore: refactoring ExpirationDuration #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jjchen01
commented
Sep 17, 2025
jjchen01
commented
- Centralize AccessTokenExpirationDuration and RefreshTokenExpirationDuration in one location.
- Remove test endpoint
- Remove unnecessary code.
jjchen01
commented
Sep 17, 2025
Comment on lines
-199
to
-208
| // Use handleGoogleToken to calculate expiration with buffer | ||
| // Instead of hardcoded 15 minutes, the access token now uses the actual expiration time from Google's token response | ||
| accessTokenExp, err := handleGoogleToken(tokenResp) | ||
| if err != nil { | ||
| reqCtx.AbortWithStatusJSON(http.StatusInternalServerError, responses.ErrorResponse{ | ||
| Code: "c6d6bafd-b9f3-4ebb-9c90-a21b07308ebc", | ||
| Error: err.Error(), | ||
| }) | ||
| return | ||
| } |
There was a problem hiding this comment.
Remove unnecessary code and misleading comments, token from the third party has been verified in:
verifier := googleAuthAPI.oidcProvider.Verifier(&oidc.Config{ClientID: googleAuthAPI.oAuth2Config.ClientID})
idToken, err := verifier.Verify(reqCtx, rawIDToken)
if err != nil {
reqCtx.AbortWithStatusJSON(http.StatusBadRequest, responses.ErrorResponse{
Code: "8ea31139-211e-4282-82de-9664814e6f46",
Error: err.Error(),
})
return
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.