Skip to content

Feat/conversation functions #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 18, 2025
Merged

Feat/conversation functions #149

merged 13 commits into from
Sep 18, 2025

Conversation

locnguyen1986
Copy link
Contributor

Conversation Flows Modifications:

  • Structure the flow for non-stream and stream
  • Save function call and tool call for conversation loadings
  • Simplify parsing logic so we can reuse in Responses APi

jjchen01
jjchen01 reviewed Sep 18, 2025
View reviewed changes
apps/jan-api-gateway/application/app/interfaces/http/routes/v1/chat/completion_route.go
type ExtendedChatCompletionRequest struct {
openai.ChatCompletionRequest
Conversation string `json:"conversation,omitempty"`
Conversation string `json:"conversation,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConversationID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's conversation id.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename it to conversation id?

jjchen01
jjchen01 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@jjchen01 jjchen01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to refactor the /chat/completions endpoint.

  • Seperate the logic of building response to a factory or jquery-like builder
  • Unnecessary validation leads to functions with too many arguments.

Merge it and integrate with the client for now.

@locnguyen1986 locnguyen1986 merged commit 0a02b82 into main Sep 18, 2025
1 check passed
@locnguyen1986 locnguyen1986 deleted the feat/conversation-functions branch September 18, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjchen01 jjchen01 jjchen01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@locnguyen1986 @jjchen01