Feat/verify invite email #175
Conversation
jjchen01
commented
Sep 24, 2025
jjchen01
commented
- Verify inviate
| return nil, err | ||
| } | ||
| if userEntity != nil { | ||
| user = userEntity |
There was a problem hiding this comment.
this line can be removed
| }) | ||
| if err != nil || inviteEntity == nil { | ||
| reqCtx.AbortWithStatusJSON(http.StatusBadRequest, responses.ErrorResponse{ | ||
| Code: "dc9e8394-2c28-40c9-93e1-7878f67992c4", |
There was a problem hiding this comment.
we may return the message to user here:
Like: "code not found" "code is expired"
There was a problem hiding this comment.
returned in:
if inviteEntity.IsExpired() {
There was a problem hiding this comment.
Invalid status for
if err != nil || inviteEntity == nil {
| } | ||
|
|
||
| owner, err := api.authService.FindOrRegisterUser(ctx, &user.User{ | ||
| Name: "Admin", |
There was a problem hiding this comment.
can we have a better name? :D like "normal user" :D :D
There was a problem hiding this comment.
Or use the guest name, but if the user logs in with the proper OIDC provider, we will replace it. In most cases, they won't see the Admin.
| projects, err := api.projectService.Find(ctx, project.ProjectFilter{ | ||
| PublicIDs: &projectPublicIDs, | ||
| }, nil) | ||
| if err != nil { |
There was a problem hiding this comment.
the question here, if error thrown, can user click the invite link again?
There was a problem hiding this comment.
Yes, the error is a server error and will be rolled back.
|
|
||
| func (inviteRoute *InvitesRoute) RegisterRouter(router gin.IRouter) { | ||
| // public router | ||
| router.POST("/invites/verification", inviteRoute.VerifyInvites) |
There was a problem hiding this comment.
put the invite url here seem weird
I think /v1/invites/verification is good.
No need to map with organization here.
There was a problem hiding this comment.
It's the invitation to the organization.
There was a problem hiding this comment.
Add the missing organization logic above.
2 participants
