Chore: refactor charts #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiento09
force-pushed
the
chore/refactor-charts
branch
from
cf39df1 to
e065bca
Compare
hiento09
force-pushed
the
chore/refactor-charts
branch
from
508c00e to
5b5a487
Compare
jjchen01
approved these changes
Sep 26, 2025
| {{- else }} | ||
| # External PostgreSQL with plain values | ||
| WRITE_DSN="host={{ .Values.externalPostgresql.host }} user={{ .Values.externalPostgresql.username }} password={{ .Values.externalPostgresql.password }} dbname={{ .Values.externalPostgresql.database }} port={{ .Values.externalPostgresql.port }} sslmode=disable" | ||
| READ_DSN="host={{ .Values.externalPostgresql.host }} user={{ .Values.externalPostgresql.username }} password={{ .Values.externalPostgresql.password }} dbname={{ .Values.externalPostgresql.database }} port={{ .Values.externalPostgresql.port }} sslmode=disable" |
There was a problem hiding this comment.
Actually, I used to receive read_dsn as an array. However, let's keep it this way for now, since modifying it later would require changing the traffic splitting strategy from the ingress rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the old per-service Helm charts for
jan-api-gatewayandjan-inference-model, and updates the documentation and configuration to use a new consolidatedjan-gatewayHelm chart as the main deployment chart. It also removes the Dockerfiles, mock server, and related documentation for thejan-inference-modelapp, simplifying the repository structure and deployment process.The most important changes are:
Helm Chart Consolidation and Cleanup:
apps-charts/jan-api-gatewayandapps-charts/jan-inference-modelHelm charts, including all templates, values files, and helpers. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]charts/jan-gateway/Chart.yamlas the main deployment chart, with dependencies for PostgreSQL and Valkey.Documentation and Configuration Updates:
README.mdto referencecharts/jan-gatewayinstead of the removedumbrella-chart, and removed references to the old per-service charts. [1] [2] [3] [4] [5].gitignorefiles to reflect the new chart structure. [1] [2]jan-inference-model Cleanup:
apps/jan-inference-model/README.md,Dockerfile,Dockerfile.mock, and the mock server code and requirements, as well as related ignore rules. [1] [2] [3] [4] [5] [6]These changes simplify deployment and maintenance by consolidating Helm charts and removing unused or redundant files.