Switch to use Redis Universal connections #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjchen01
approved these changes
Sep 29, 2025
| func NewRedisCacheService() *RedisCacheService { | ||
| redisURL := environment_variables.EnvironmentVariables.REDIS_URL | ||
| if redisURL == "" { | ||
| panic("REDIS_URL environment variable must be set") |
There was a problem hiding this comment.
Sorry, I missed this. If you have a moment, please make NewRedisCacheService() return an error. If NewRedisCacheService() returns an error, panic with that error.
There was a problem hiding this comment.
let me return err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our dev is using Cluster.
I switch the connections type to support both single and cluster Redis server