Skip to content

Conversation

locnguyen1986
Copy link
Contributor

Support multiple admin emails of default organization

Copy link
Collaborator

@jjchen01 jjchen01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fix comments please

admin, err := s.userService.FindByEmail(ctx, email)
if err != nil {
return err
emails := strings.Split(environment_variables.EnvironmentVariables.ORGANIZATION_ADMIN_EMAIL, ",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORGANIZATION_ADMIN_EMAIL -> ORGANIZATION_ADMIN_EMAILS

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, EnvironmentVariables supports []string.

@locnguyen1986 locnguyen1986 merged commit 68b8514 into main Sep 29, 2025
1 check passed
@locnguyen1986 locnguyen1986 deleted the feat/support-multiple-admin-emails branch September 29, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants