-
Notifications
You must be signed in to change notification settings - Fork 38
Custom Themes "overhaul" #211
base: develop
Are you sure you want to change the base?
Conversation
Deploying with
|
| Latest commit: |
7078df9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad3e2dd0.meower-svelte.pages.dev |
| Branch Preview URL: | https://custom-themes-v2.meower-svelte.pages.dev |
showierdata9978
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foregroundOrange should probably be renamed to secondary
showierdata9978
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foregroundOrange should probably be renamed to secondary
|
This should not happen. v1 already supports not including |
|
I like the idea of the reset buttons though. |
|
they should just be simplified, instead of teh orange stuff, use terms like primary, secondary, etc |
so do i scrap v2 and just edit v1 to not care about orangelight and dark? |
v1 already doesn't care about orangeLight and orangeDark. But yes, you should scrap v2, it's a pointless change. |
|
another PR is using v2 rn too. |
Just use fallback on error
Changes: