Skip to content

Fix rediscache concurrent access#72

Open
juntaki wants to merge 1 commit intomercari:masterfrom
juntaki:fix-rediscache
Open

Fix rediscache concurrent access#72
juntaki wants to merge 1 commit intomercari:masterfrom
juntaki:fix-rediscache

Conversation

@juntaki
Copy link

@juntaki juntaki commented Dec 22, 2019

It seems that concurrent access is not supported by rediscache.
Current implementation, One client (may be injected to an application) use single connection.
https://godoc.org/github.com/garyburd/redigo/redis#hdr-Concurrency

I switch redis client from gomodule/redigo to go-redis/redis. go-redis supports concurrent Tx pipeline.

@vvakame
Copy link
Member

vvakame commented Dec 2, 2020

@juntaki sorry for very late response...
so, I don't wanna make breaking change.
could you try to support both redis client? (e.g. make rediscache2 package, make rediscache.New2 func, or any other good idea you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants