fix: propagate isWorkspaceMigratedToGHE & merge dev & bump code-server to 1.9.10#4954
Open
agnelpraveen wants to merge 4 commits into
Open
fix: propagate isWorkspaceMigratedToGHE & merge dev & bump code-server to 1.9.10#4954agnelpraveen wants to merge 4 commits into
agnelpraveen wants to merge 4 commits into
Conversation
…borator workspace When adding a collaborator to a codespace workspace, a new workspace entity is created for the collaborator. Previously, the isWorkspaceMigratedToGHE and isWorkspaceMigrated fields were not being copied from the owner's workspace, resulting in null values for collaborators. This caused issues with Git operations that depend on knowing whether the workspace uses GHE or git.i. Fixed in both: - addCollabById(): adding collaborator to existing workspace - createWorkspace(): creating collaborator workspaces during initial creation Co-Authored-By: anna_agnel.maria_rathinam <anna_agnel.maria_rathinam@mercedes-benz.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
agnelpraveen
changed the title
…ffective permissions Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When adding a collaborator to a codespace workspace, a new workspace entity is created for the collaborator. Previously, the
isWorkspaceMigratedToGHEandisWorkspaceMigratedfields were not being copied from the owner's workspace, resulting innullvalues for collaborators. This caused issues with Git operations that depend on knowing whether the workspace uses GHE or git.i.Changes
Fixed in
BaseWorkspaceService.javaby adding two lines to copy the migration flags from the owner workspace to the collaborator workspace entity:addCollabById(): when adding a collaborator to an existing workspacecreateWorkspace(): when creating collaborator workspaces during initial workspace creationRoot Cause
The
CodeServerWorkspaceentity hasisWorkspaceMigratedToGHEandisWorkspaceMigratedboolean fields that track whether a workspace has been migrated to GitHub Enterprise. When collaborator workspace entities were created, all other fields (description, gitUserName, projectDetails, status, etc.) were copied from the owner workspace, but these two migration flags were omitted.